Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed main 2023 and 2024 #174

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Fixed main 2023 and 2024 #174

merged 1 commit into from
Jun 8, 2024

Conversation

mgupta27
Copy link
Contributor

@mgupta27 mgupta27 commented Jun 7, 2024

Fixed main 2023 and 2024

Problems

  • main_2024.py
    • The config key for the logger wasn't configured properly so it was throwing a KeyError
  • main_2023.py
    • Did not have show annotated flag implemented

Key Changes

  • Fixed both main_2023.py and main_2024.py
  • Updated common submodule commit hash

DylanFinlay
DylanFinlay approved these changes Jun 8, 2024
View reviewed changes
Copy link
Contributor

@DylanFinlay DylanFinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgupta27 mgupta27 merged commit 977c71f into main Jun 8, 2024
1 check passed
@mgupta27 mgupta27 deleted the mihir.fix-main-2023-and-2024 branch June 8, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanFinlay DylanFinlay DylanFinlay approved these changes

@TongguangZhang TongguangZhang Awaiting requested review from TongguangZhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgupta27 @DylanFinlay