Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added baud rate parameter in config.yaml #184

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Added baud rate parameter in config.yaml #184

merged 2 commits into from
Jul 5, 2024

Conversation

mgupta27
Copy link
Contributor

@mgupta27 mgupta27 commented Jul 5, 2024

Added baud rate parameter in config.yaml

Key Changes

  • Added BAUD_RATE parameter in config.yaml and propagated the value to flight interface module
  • Updated common repo to get latest updates from FlightController
  • Fixed test cases and added baud rate parameter

Testing

  • All unit tests pass
  • Tested test_flight_interface_worker and test_flight_interface_hardware integration tests and confirmed they work

TongguangZhang
TongguangZhang approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@TongguangZhang TongguangZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgupta27 mgupta27 merged commit 8f5f0fc into main Jul 5, 2024
1 check passed
@mgupta27 mgupta27 deleted the mihir.set-baud-rate-in-main branch July 5, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TongguangZhang TongguangZhang TongguangZhang approved these changes

@Xierumeng Xierumeng Awaiting requested review from Xierumeng

@DylanFinlay DylanFinlay Awaiting requested review from DylanFinlay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgupta27 @TongguangZhang