Add Logging to Geolocation #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/geolocation/geolocation.py
Outdated
Comment on lines
185
to
188
| except: | ||
| # TODO: Logging | ||
| frame = inspect.currentframe() | ||
| self.__logger.error("could not get perspective transform matrix", frame) | ||
| return False, None |
There was a problem hiding this comment.
except cv2.error as e:
# log the specific cv2 error
return False, None
except Exception as e:
# log the specific unexpected error type
return False, None
modules/geolocation/geolocation.py
Outdated
Comment on lines
323
to
325
| for detection_in_world in detections_in_world: | ||
| frame = inspect.currentframe() | ||
| self.__logger.info(detection_in_world, frame) |
There was a problem hiding this comment.
we should log each one as it's created in the for loop above (after we append it to the list
Xierumeng
previously approved these changes
Jul 5, 2024
modules/geolocation/geolocation.py
Outdated
| @@ -45,6 +57,10 @@ def create( | |||
| # Image space to camera space | |||
| result, value = camera_intrinsics.camera_space_from_image_space(source[0], source[1]) | |||
| if not result: | |||
| frame = inspect.currentframe() | |||
| geolocation_logger.error( | |||
| f"rotated source vector could not be created for source: {source}", frame | |||
There was a problem hiding this comment.
Capitalize. Same for logging statements below.
There was a problem hiding this comment.
Sounds good. I noticed in main the logger outpus main logger initialized which is why I did all lowercase. Should those be changed as well?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Logging to Geolocation
Key Changes
DetectionInWorldTesting
test_geolocation_workerintegration test works and confirm logs are logged as expectedOutput from log file