Fix landing pad tracking return #207
Conversation
| @@ -54,10 +54,14 @@ def mark_confirmed_positive(self, detection: object_in_world.ObjectInWorld) -> N | |||
|
|
|||
There was a problem hiding this comment.
Why does the mark false positive remove it from unconfirmed positives, but confirmed positive does not?
There was a problem hiding this comment.
No idea, I will investigate.
| @@ -82,16 +86,16 @@ def run( | |||
| # If new landing pad, add to list of unconfirmed positives | |||
| self.__unconfirmed_positives.append(detection) | |||
There was a problem hiding this comment.
This seems to add it regardless of it already exists or not in the list?
There was a problem hiding this comment.
The expectation is that the input is already filtered (I think). I can add it to the docstring.
Actually, might be a bug.
There was a problem hiding this comment.
it breaks if it finds a match right? so it only gets added if the loop doesn't get broken
There was a problem hiding this comment.
Yes, you are correct. continue will skip.
| @@ -82,16 +86,16 @@ def run( | |||
| # If new landing pad, add to list of unconfirmed positives | |||
| self.__unconfirmed_positives.append(detection) | |||
There was a problem hiding this comment.
it breaks if it finds a match right? so it only gets added if the loop doesn't get broken
| if len(self.__confirmed_positives) > 0: | ||
| return True, self.__confirmed_positives[0] |
There was a problem hiding this comment.
this changes the behaviour of decision module right?
There was a problem hiding this comment.
Yes, this is the fix.
Changed return from single object in world to list of object in world.