initial commit #216
Closed
initial commit #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xierumeng
reviewed
Nov 1, 2024
| ) -> tuple[bool, list[DetectionInWorld] | None]: | ||
| for detection_in_world in detections_in_world: | ||
| if len(detection_in_world.centre) == 3: | ||
| result, detection_in_world_global = drone_position_global_from_local( |
There was a problem hiding this comment.
Create a new function in the local_global_conversion library that returns a DetectionInWorld in global space after taking in home position and DetectionInWorld in local space.
If you want to be extra safe, you could create a new class solely for global locations (e.g. LocationGlobal ). Hmm, now that I think about it, surely that class must already exist somewhere (maybe in pathing repository)?
maxlou05
force-pushed
the
communication_worker
branch
from
7e7dc61 to
74f5c2e
Compare
…mmunication worker
|
Implemented in PR #277 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.