Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showing annotated images for detect target message bug fix #230

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

arpanroy18
Copy link

Fixed annotation bug so that opencv can display images in a GUI for detect_target.

Copy link
Member

@maxlou05 maxlou05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

modules/.DS_Store Outdated Show resolved Hide resolved
.DS_Store Outdated Show resolved Hide resolved
modules/detect_target/detect_target_factory.py Outdated Show resolved Hide resolved
modules/detect_target/detect_target_factory.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

modules/detect_target/detect_target_ultralytics.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

modules/detect_target/detect_target_factory.py Outdated Show resolved Hide resolved
modules/detect_target/detect_target_factory.py Outdated Show resolved Hide resolved
modules/detect_target/detect_target_ultralytics.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

Comment on lines +32 to +33
Returns:
Success, detect target object.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return: Success, detect target object.

@@ -39,5 +42,4 @@ def create_detect_target(
show_annotations,
save_name,
)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore empty line.

Comment on lines +49 to +51
if self.__device != "cpu" and not torch.cuda.is_available():
self.__local_logger.warning("CUDA not available. Falling back to CPU.")
self.__device = "cpu"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty line above this line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants