Bootcamp: Lily Wang #165
Open
Bootcamp: Lily Wang #165
+5,944
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Penguronik
requested changes
Jan 23, 2025
|
|
||
| //adc value is 10 bits so rxData[1] stores 2 MSBs and rxData[2] stores the 8 remaining since data can only be sent in 8 bits | ||
| uint16_t adcValue = ((rxData[1]&0x03)<<8 | rxData[2]); | ||
| compareValue = (adcValue * maxTimerCounts)/maxADCValue; |
There was a problem hiding this comment.
Remember to shift this to be from 5% to 10% of your PWM period
| //bring CS to low to select ADC | ||
| HAL_GPIO_WritePin(GPIOB,GPIO_PIN_8,GPIO_PIN_RESET); | ||
| //transmit and receive data from ADC simultaneously | ||
| HAL_SPI_TransmitReceive(&hspi1,txData,rxData,2,HAL_MAX_DELAY); |
There was a problem hiding this comment.
Since you're sending and receiving 3 bytes, you would need to update the size value
|
|
||
| uint8_t txData[3] = {0}; | ||
| uint8_t rxData[3] = {0}; | ||
| uint16_t adcValue = 0x00; |
There was a problem hiding this comment.
Looks like you redeclare the variable down below
| /* USER CODE BEGIN 2 */ | ||
|
|
||
| uint8_t txData[3] = {0}; |
There was a problem hiding this comment.
Check out page 21 of https://cdn-shop.adafruit.com/datasheets/MCP3008.pdf to see what value you need to send
| uint16_t adcValue = 0x00; | ||
| uint16_t compareValue = 0x00; | ||
| uint16_t maxTimerCounts = 10000; //Auto-reload register | ||
| uint16_t maxADCValue = 1023; //10 bits | ||
| /* USER CODE END 2 */ | ||
|
|
There was a problem hiding this comment.
Make sure you call the appropriate HAL PWM start function here (you should be able to find it with a quick google search)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.