fixed waypoints_to_spline_commands #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xierumeng
reviewed
Dec 5, 2023
Comment on lines
19
to
20
| waypoints, | ||
| altitude |
There was a problem hiding this comment.
This should be intended by 1 more than result, ... = . See test_waypoints_names_to_coordinates.py for an example.
| result, commands_actual = waypoints_to_spline_commands.waypoints_to_spline_commands( | ||
| waypoints, | ||
| altitude | ||
| ) |
There was a problem hiding this comment.
This should be at the same indentation level as result, ... = . See test_waypoints_names_to_coordinates.py for an example.
Comment on lines
39
to
41
| waypoints, | ||
| altitude | ||
| ) |
Xierumeng
reviewed
Dec 8, 2023
| altitude = 100 | ||
|
|
||
| result, commands_actual = waypoints_to_spline_commands.waypoints_to_spline_commands( | ||
| waypoints, |
There was a problem hiding this comment.
Remove extra space after the comma.
|
|
||
| result, commands_actual = waypoints_to_spline_commands.waypoints_to_spline_commands( | ||
| waypoints, | ||
| altitude |
There was a problem hiding this comment.
Add comma at end of this line.
Comment on lines
+39
to
+40
| waypoints, | ||
| altitude |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.