Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hotspot search path generation #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add hotspot search path generation #77

wants to merge 1 commit into from

Conversation

siddhp1
Copy link

@siddhp1 siddhp1 commented Nov 22, 2024

No description provided.

janez45
janez45 reviewed Dec 29, 2024
View reviewed changes
Copy link
Contributor

@janez45 janez45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, so sorry for the late review! Hope exams went well and that you're having a good and restful break

modules/generate_hotspot_search_path.py

while current_radius <= search_radius:
circumference = 2 * math.pi * current_radius
num_points = max(MINIMUM_POINTS, int(circumference / camera_vertical_size))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go with ceil for this to play it safer. Maybe also add a multiplier, like 1.2 to allow for more wiggle room.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also to error on the side of caution, also check if with camera_horizontal_size would yield a higher value.

tests/unit/test_generate_hotspot_search_path.py

waypoint_index += num_points
current_radius += camera_width

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna be tedious... but could you hard code the test numbers? So like actual values that are expected of the path. Doesn't have to be extremely complicated, but enough to gauge performance. You can take a look at /Users/janez/Development/WARG/pathing/tests/unit/test_plot_circular_path.py for an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janez45 janez45 janez45 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddhp1 @janez45