Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/generated downloads #138

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Bugfix/generated downloads #138

merged 7 commits into from
Mar 21, 2024

Conversation

srappel
Copy link
Member

@srappel srappel commented Mar 21, 2024

Forces downloads into a new folder to avoid needing to create the tmp/cached/downloads folder on each deploy.

@srappel
Copy link
Member Author

srappel commented Mar 21, 2024

This resolves #135

@srappel
Copy link
Member Author

srappel commented Mar 21, 2024

Even though there's a bunch of commits here, the only actual change after everything is to force add tmp/cache/downloads/.keep to make sure that dir is created when the repo is cloned.

This didn't require any modification to .gitignore, but it did require using git add -f tmp/cached/downloads/.keep to make sure that the empty dir was "tracked"

@srappel srappel marked this pull request as ready for review March 21, 2024 14:41
@srappel srappel merged commit b1a56dd into main Mar 21, 2024
3 checks passed
@srappel srappel deleted the bugfix/generated-downloads branch March 21, 2024 14:41
@srappel srappel restored the bugfix/generated-downloads branch April 3, 2024 20:13
@srappel srappel deleted the bugfix/generated-downloads branch July 16, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed!
Development

Successfully merging this pull request may close these issues.

1 participant