Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat template #14

Merged
merged 6 commits into from
Sep 22, 2024
Merged

Compat template #14

merged 6 commits into from
Sep 22, 2024

Conversation

ZestyTS
Copy link
Contributor

@ZestyTS ZestyTS commented Sep 20, 2024

Made the compat page into a template.

@ZestyTS ZestyTS added the enhancement New feature or request label Sep 20, 2024
@ZestyTS ZestyTS requested a review from NicoAICP September 20, 2024 07:44
@NicoAICP
Copy link
Member

@ZestyTS I updated the Template to display, as example, NDS instead of NDSCompat.

There is 2 Issues i found out tho:

  • in the src/router/index.js files, your props do nothing. Thats why i made aboves commit.

  • The Navigation bar does not work anymore. Open /nescompat for example via the url and then press the Compatibility -> NDS button. It will stay at NES. Only way to switch is NES -> HOME -> NDS

@ZestyTS
Copy link
Contributor Author

ZestyTS commented Sep 20, 2024

@NicoAICP I made some changes.

  • Fixed routing, now you can go directly to the other page without having to go back to home
  • Removed the props and instead made a dynamic route
  • Fixed the code for getting the json.

There is currently a bug and that has to do with manually typing in the URL, I believe that when it goes live that bug will fix itself since gh-pages doesn't do dynamic routing in the first place.

@NicoAICP
Copy link
Member

Looks good.

@NicoAICP NicoAICP merged commit b02beed into development Sep 22, 2024
1 check passed
@NicoAICP NicoAICP deleted the CompatTemplate branch September 22, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants