Update react-scripts and Typescript to version 4 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRA 4 defaults this to true, which broke jest-mock-axios and therefore every test we have.
This fixes a type error we were getting on deleting window.document.cookie, which is invalid, since that field is not optional.
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
- Coverage 59.55% 59.54% -0.02%
==========================================
Files 63 63
Lines 1533 1535 +2
Branches 388 390 +2
==========================================
+ Hits 913 914 +1
Misses 588 588
- Partials 32 33 +1
Continue to review full report at Codecov.
|
The client manifest generation script relies on export default being there, so we just ignore the eslint rule.
This avoids the eslint error we were getting in config.ts before, and makes the manifest generation code less fragile
size-limit report
|
tyxchen
requested changes
Jan 17, 2021
|
Turns out I had format on save disabled in VS Code for some reason, which explains why those format issues got through. |
tyxchen
added
blocking
tyxchen
approved these changes
Feb 15, 2021
|
So it looks like the security check got disabled because of inactivity. It should be good to merge anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates react-scripts and Typescript to major version 4.
The following changes were required to deal with breaking changes:
eslintto avoid conflicts with the versionreact-scriptsprovides. Oureslintrchas been moved topackage.json, where the docs recommend ESLint configuration is done.'react-router-domLinks, since the issue we were trying to work around has been fixed.react-refreshlooking for$$typeofon every export. This should be temporary until we deliver a more lasting fix to the errors proxy.resetMockstofalseinpackage.json. CRA 4 changed this option totrueby default which breaksjest-mock-axios. Tracking issue here.config.tsfile, and makes the manifest generation code less fragile.