Dbow3 integration #784
Closed
Dbow3 integration #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A part of creating our working environment
Changes for compiling the src
change boolean to run viewer
Adding benchmark script
Adding socre and room to benchmark file (was missing)
Second attempt to integrate
|
Disclaimer: I don't intend to create spam. If the ORB_SLAM3 developers wish me to stop posting, I will cease immediately. Hello @yinonb4 , because ORB_SLAM3 is inactive, I am compiling a version with all the best community bugfixes/improvements at https://github.com/jeremysalwen/ORB_SLAM_COMMUNITY. I am curious about what benefits you found from switching DBoW2 with DBoW3. Does this improve accuracy or runtime? |
|
From DBOW3 repo:
It seems that this only improves runtime. |
namtacs
approved these changes
Aug 16, 2024
| @@ -37,4 +37,4 @@ echo "Configuring and building ORB_SLAM3 ..." | |||
| mkdir build | |||
| cd build | |||
| cmake .. -DCMAKE_BUILD_TYPE=Release | |||
| make -j4 | |||
Repository owner
closed this by deleting the head repository
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing DBoW2 with DBoW3, with proper integration.
Code taken from:
https://github.com/rmsalinas/DBow3.git