-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composite actions #28
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sehe den Vorteil der Action nicht ganz. Der Play Store Build dauert so länger, weil die Builds seriell laufen. Und der Actions-Moloch wird noch komplexer.
default: 'app' | ||
main_branch: | ||
required: false | ||
default: 'main' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Geht das auch mit Tags?
default: 'app' | ||
main_branch: | ||
required: false | ||
default: 'main' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Würde hier keinen Default setzen, sollte explizit sein.
self_hosted_cache_secret_key: ${{ inputs.self_hosted_cache_secret_key }} | ||
|
||
# Setup the build environment with Gradle | ||
- name: Publish the app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wie funktioniert das im Zusammenspiel mit den Flavors? Ich will ja keinen Dev-Build releasen.
@@ -0,0 +1,156 @@ | |||
name: Build and Upload to UBDiag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicht mehr ganz richtig.
Bin mir auch noch nicht ganz sicher ob das effektiv das ist was wir erreichen wollen. Der Vorteil einer Composite Action gegenüber eines Reusable Workflows ist ja, dass man diese im gleichen Workflow mit anderen Actions kombinieren kann, wohingegen der Reusable Workflow ein gekapselter, "fertiger" Workflow ist, der nur parametrisiert werden muss. |
Beispiel Verwendung: https://github.com/UbiqueInnovation/swisstopo-android/pull/112