Add certificate to fix unit test #86
Conversation
|
Warning Rate Limit Exceeded@maerki has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 7 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent changes bring enhancements in accessibility features and workflow optimizations. Accessibility improvements include making a key method publicly accessible, while workflow refinements involve renaming job names and streamlining build workflow steps. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Sources/UBFoundation/Helpers/UIAccessibility+Helper.swift (1 hunks)
Additional comments not posted (2)
Sources/UBFoundation/Helpers/UIAccessibility+Helper.swift (2)
10-10: Visibility of the extension changed to public.Ensure that no internal methods are unintentionally exposed due to this change.
13-13: Visibility of the methodub_postHighPriorityAnnouncementchanged to internal.Verify that this change aligns with the intended use of the method within the module.
There was a problem hiding this comment.
Actionable comments posted: 20
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- Tests/UBFoundationTests/Cron/CronJobTests.swift (2 hunks)
- Tests/UBFoundationTests/Networking/HTTPDataDecoderTests.swift (1 hunks)
- Tests/UBFoundationTests/Networking/HTTPDataTaskTests.swift (17 hunks)
- Tests/UBFoundationTests/Networking/HTTPRequestInterceptorsTests.swift (2 hunks)
- Tests/UBFoundationTests/Networking/HTTPRequestModifierTests.swift (8 hunks)
- Tests/UBFoundationTests/Networking/HTTPResponseValidatorTests.swift (2 hunks)
- Tests/UBFoundationTests/Networking/NetworkActivityTrackerTests.swift (1 hunks)
- Tests/UBFoundationTests/Networking/UBSessionTests.swift (10 hunks)
Files skipped from review due to trivial changes (5)
- Tests/UBFoundationTests/Networking/HTTPDataDecoderTests.swift
- Tests/UBFoundationTests/Networking/HTTPRequestInterceptorsTests.swift
- Tests/UBFoundationTests/Networking/HTTPRequestModifierTests.swift
- Tests/UBFoundationTests/Networking/HTTPResponseValidatorTests.swift
- Tests/UBFoundationTests/Networking/UBSessionTests.swift
| @@ -40,6 +40,6 @@ class NetworkActivityTrackerTests: XCTestCase { | |||
| dataTask.start() | |||
| dataTask2.start() | |||
|
|
|||
| waitForExpectations(timeout: 1, handler: nil) | |||
| waitForExpectations(timeout: 30, handler: nil) | |||
There was a problem hiding this comment.
Consider reducing the timeout for waitForExpectations to a more reasonable duration.
Reducing the timeout can help in identifying hanging tests more quickly and can improve the overall test execution time.
| @@ -132,7 +132,7 @@ class CronJobTests: XCTestCase { | |||
| } | |||
| RunLoop.main.add(t, forMode: .common) | |||
|
|
|||
| waitForExpectations(timeout: 1, handler: nil) | |||
| waitForExpectations(timeout: 30, handler: nil) | |||
There was a problem hiding this comment.
Consider reducing the timeout for waitForExpectations to a more reasonable duration.
A timeout of 30 seconds seems excessive for a test that is expected to complete in less than a second. Reducing the timeout can help in identifying hanging tests more quickly and can improve the overall test execution time.
| @@ -151,7 +151,7 @@ | |||
| } | |||
| RunLoop.main.add(t, forMode: .common) | |||
|
|
|||
| waitForExpectations(timeout: 1, handler: nil) | |||
| waitForExpectations(timeout: 30, handler: nil) | |||
There was a problem hiding this comment.
Consider reducing the timeout for waitForExpectations to a more reasonable duration.
A timeout of 30 seconds seems excessive for a test that is expected to complete in less than a second. Reducing the timeout can help in identifying hanging tests more quickly and can improve the overall test execution time.
| @@ -35,7 +35,7 @@ class HTTPDataTaskTests: XCTestCase { | |||
| ex1.fulfill() | |||
| } | |||
|
|
|||
| waitForExpectations(timeout: 1, handler: nil) | |||
| waitForExpectations(timeout: 30, handler: nil) | |||
There was a problem hiding this comment.
Consider reducing the timeout for waitForExpectations to a more reasonable duration.
A timeout of 30 seconds seems excessive for a test that is expected to complete in less than a second. Reducing the timeout can help in identifying hanging tests more quickly and can improve the overall test execution time.
| @@ -68,7 +68,7 @@ | |||
| ex1.fulfill() | |||
| } | |||
| dataTask.start() | |||
| waitForExpectations(timeout: 1, handler: nil) | |||
| waitForExpectations(timeout: 30, handler: nil) | |||
There was a problem hiding this comment.
Consider reducing the timeout for waitForExpectations to a more reasonable duration.
A timeout of 30 seconds seems excessive for a test that is expected to complete in less than a second. Reducing the timeout can help in identifying hanging tests more quickly and can improve the overall test execution time.
| @@ -410,7 +410,7 @@ | |||
| } | |||
| } | |||
| dataTask.start() | |||
| waitForExpectations(timeout: 1, handler: nil) | |||
| waitForExpectations(timeout: 30, handler: nil) | |||
There was a problem hiding this comment.
Consider reducing the timeout for waitForExpectations to a more reasonable duration.
A timeout of 30 seconds seems excessive for a test that is expected to complete in less than a second. Reducing the timeout can help in identifying hanging tests more quickly and can improve the overall test execution time.
| @@ -458,7 +458,7 @@ | |||
| } | |||
| RunLoop.main.add(t, forMode: .common) | |||
|
|
|||
| waitForExpectations(timeout: 1, handler: nil) | |||
| waitForExpectations(timeout: 30, handler: nil) | |||
There was a problem hiding this comment.
Consider reducing the timeout for waitForExpectations to a more reasonable duration.
A timeout of 30 seconds seems excessive for a test that is expected to complete in less than a second. Reducing the timeout can help in identifying hanging tests more quickly and can improve the overall test execution time.
| @@ -523,7 +523,7 @@ | |||
| } | |||
| RunLoop.main.add(t, forMode: .common) | |||
|
|
|||
| waitForExpectations(timeout: 1, handler: nil) | |||
| waitForExpectations(timeout: 30, handler: nil) | |||
There was a problem hiding this comment.
Consider reducing the timeout for waitForExpectations to a more reasonable duration.
A timeout of 30 seconds seems excessive for a test that is expected to complete in less than a second. Reducing the timeout can help in identifying hanging tests more quickly and can improve the overall test execution time.
| @@ -582,7 +582,7 @@ | |||
| RunLoop.main.add(t, forMode: .common) | |||
| } | |||
|
|
|||
| waitForExpectations(timeout: 1, handler: nil) | |||
| waitForExpectations(timeout: 30, handler: nil) | |||
There was a problem hiding this comment.
Consider reducing the timeout for waitForExpectations to a more reasonable duration.
A timeout of 30 seconds seems excessive for a test that is expected to complete in less than a second. Reducing the timeout can help in identifying hanging tests more quickly and can improve the overall test execution time.
| @@ -635,6 +635,6 @@ | |||
|
|
|||
| dataTask.start() | |||
|
|
|||
| waitForExpectations(timeout: 1, handler: nil) | |||
| waitForExpectations(timeout: 30, handler: nil) | |||
There was a problem hiding this comment.
Consider reducing the timeout for waitForExpectations to a more reasonable duration.
A timeout of 30 seconds seems excessive for a test that is expected to complete in less than a second. Reducing the timeout can help in identifying hanging tests more quickly and can improve the overall test execution time.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/build.yml (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/build.yml
|
Summary by CodeRabbit