-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE Challenge Pedro Neves #29
Open
psnev89
wants to merge
28
commits into
Unbabel:master
Choose a base branch
from
psnev89:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there is a product at Unbabel that uses micro frontends, I decided to go for a npm workspaces approach, decoupling possible shared/common modules. In this case, I only decoupled the API part, but could also be made for base UI components.
Also, the app is running a late vue 2 version, meaning that allows the use of the composition API, which I used.
Things I highlight:
useTranscriptionsStore
composable that manages transcriptions' module state.useTranscriptionsService
composable that handles app and API "connection". Works as a translation layer, If anything on the API changes, we'll only need to change it here.TranscriptionReadModel
class. This is a pattern that I personally like. It works like a helper for the View Model, with only readonly properties. It allows us to "lock" specific component prop types while also being the single source of truth for all thetranscription
's properties display.As I don't have much free time, I tried to be pragmatic. Some improvements that could be made: