Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master #5

Open
wants to merge 879 commits into
base: master
Choose a base branch
from
Open

Master #5

wants to merge 879 commits into from

Conversation

darrynten
Copy link
Member

Import upstream master branch

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Mar 19, 2020
@pull-assistant
Copy link

pull-assistant bot commented Mar 19, 2020 •
edited
Loading

Score: 0.97

Best reviewed: commit by commit

Optimal code review plan (12 warnings, 3 commits squashed)

     Merge branch '10.0'

     Merge pull request #810 from laravel/webhook-events

     Adding missing phpdocs for throws on create/add methods.

     Merge pull request #813 from ericdowell/missing-phpdoc-throws

     Properly return null for find methods

     Merge pull request #817 from laravel/fix-find-method

     Update Github files

     Update link

     Update readme

Merge pull request #819 from laravel/update-github-files

.gitattributes 50% changes removed in Merge branch '10.0'

Merge branch '10.0'

.gitattributes 50% changes removed in Update templates

     Tweaks

     Merge branch '10.0'

     Further tweaks to templates

     Merge branch '10.0'

     Update coc link

     Merge branch '10.0'

Separate throws tags

src/SubscriptionBuilder.php 50% changes removed in Merge pull request #...

     Update CHANGELOG.md

     version

     Merge branch '10.0'

     Update templates

     Merge branch '10.0'

     Allow Symfony 5

     Merge pull request #822 from laravel/symfony5

     Update CHANGELOG.md

     version

     Merge branch '10.0'

     fix docs

     Merge pull request #826 from iamgergo/10.0

Test on PHP 7.4

.travis.yml 75% changes removed in Switch to Github Act...

Merge pull request #827 from laravel/php74

.travis.yml 75% changes removed in Merge pull request #...

Merge branch '10.0'

.travis.yml 50% changes removed in Switch to Github Act...

     Update to 2019-12-03 Stripe API version

     Merge pull request #828 from laravel/update-api

     Assert customer exists before retrieving

     Merge pull request #834 from laravel/assert-customer-exists

     Merge branch '10.0'

     Support default TaxRates for Subscriptions

     Localized stripe URL fixed

     Merge pull request #835 from shahariaazam/shahariaazam-patch-1

     Simplify refund method

     Merge pull request #837 from laravel/simplify-refund

     Add new hasDefaultPaymentMethod method

Implement Tax Rates on invoices

src/SubscriptionBuilder.php 50% changes removed in Merge pull request #...

     Merge pull request #838 from laravel/add-new-has-payment-method

     Update Invoice.php

     Merge pull request #830 from laravel/tax-rates

     PaymentMethod: Fix typo in exception message

     Merge pull request #846 from Xenonym/fix/paymentmethod-exception-messa...

     Fix overriding notification subject translation

     Update CHANGELOG.md

     version

     Merge branch '10.0'

Fix findInvoiceOrFail behavior

src/Billable.php 83% changes removed in Add throws and impro...

     Merge pull request #853 from laravel/fix-find-invoice-or-fail

     Update CHANGELOG.md

     version

     Merge branch '10.0'

     Add subscription options + test

     Update SubscriptionBuilder.php

     Fixes

     Merge branch 'add_subscription_options' of github.com:keithbrink/cashi...

     Update SubscriptionBuilder.php

Update as per Dries’ comments in https://github.com/laravel/cashier/...

...trollers/WebhookController.php 50% changes removed in missing ;

     missing ;

     Mark markAsCancelled as internal

Prevent createAsStripeCustomer when stripe_id is set

.../SubscriptionUpdateFailure.php 50% changes removed in Merge pull request #...

Merge pull request #871 from laravel/create-customer-exception

.../SubscriptionUpdateFailure.php 50% changes removed in Merge branch '10.0'

     Merge pull request #870 from laravel/mark-as-internal

Merge branch '10.0' of https://github.com/edalzell/cashier into edalze...

...trollers/WebhookController.php 50% changes removed in Merge branch '10.0'

     move method

     formatting

     Merge pull request #868 from keithbrink/add_subscription_options

     Update CHANGELOG.md

     version

     Merge branch '10.0'

     Add @throws declaration to methods on Billable which can throw Payment...

     Merge pull request #872 from ValCanBuild/10.0

     Switch to Github Actions

     Merge pull request #875 from laravel/github-actions

     Merge branch '10.0'

     Rename Integration test directory to Feature

     Remove param

     Correct return type

     Merge branch '10.0'

     Fix a bug with tax rates

     Merge pull request #876 from laravel/fix-tax-rate-bug

     Add getters for owner instances to objects

     Use proper invoice number

     Merge pull request #878 from laravel/use-proper-invoice-number

     Merge pull request #877 from laravel/add-owner-method

Update payment page ... ... Merge branch '10.0'

Squashed 3 commits:

     Prevent exception throwing on some methods

     Add throws and improve return types

     Fix variable name

     Merge pull request #883 from laravel/docblocks

     Merge pull request #882 from laravel/loosen-exception-throwing

Powered by Pull Assistant. Last update 630a73b ... 0b6868a. Read the comment docs.

@vizipi
Copy link

vizipi bot commented Mar 19, 2020 •
edited
Loading

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
8.22 % Steve Ops 5 6

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
tests/Integration/LoggerTest.php50.00 %1 out of 2 times
config/cashier.php50.00 %1 out of 2 times
LUMEN.md50.00 %1 out of 2 times
tests/TestCase.php50.00 %1 out of 2 times
tests/Fixtures/Auth/User.php50.00 %1 out of 2 times
src/CashierServiceProvider.php50.00 %1 out of 2 times
tests/Integration/WebhooksTest.php50.00 %1 out of 2 times
routes/web.php50.00 %1 out of 2 times
tests/Integration/CustomerTest.php50.00 %1 out of 2 times
tests/Integration/VerifyWebhookSignatureTest.php50.00 %1 out of 2 times

Committed file ranks

(click to expand)
  • 68.18%[src/Subscription.php]
  • 38.64%[src/Invoice.php]
  • 38.64%[src/SubscriptionBuilder.php]
  • 68.18%[CHANGELOG.md]
  • 68.18%[src/Http/Controllers/PaymentController.php]
  • 38.64%[src/Http/Controllers/WebhookController.php]
  • 0.00%[src/Exceptions/SubscriptionUpdateFailure.php]
  • 97.73%[composer.json]
  • 93.18%[src/Cashier.php]
  • 0.00%[tests/Unit/SubscriptionTest.php]

    • @vizipi vizipi bot requested a review from steveops March 19, 2020 04:48
    driesvints and others added 25 commits April 5, 2022 15:24
    @driesvints @actions-user
    Update CHANGELOG
    794dacb
    @driesvints
    Create pull-requests.yml
    9b297d1
    @driesvints
    [13.x] Throw deprecations in tests (#1342)
    c5022b7 
    * Update tests.yml

* wip
    @driesvints
    Fix issue with zero tax on invoice (#1343)
    cac24ae
    @driesvints
    Update Cashier.php
    2147b8e
    @driesvints @actions-user
    Update CHANGELOG
    fb5473a
    @driesvints
    Merge branch '13.x'
    3bb2035 
    # Conflicts:
#	CHANGELOG.md
#	composer.json
#	src/Cashier.php
    @mozex @driesvints
    [13.x] Add pay method (#1345)
    90deda5 
    * Add createPaymentIntent Method

* Fix StyleCI Errors

* Fix StyleCI Errors :(

* Fix StyleCI Spacing Error

* Fix StyleCI Spacing Error :(

* Add new pay method

* Forward calls on Payment instance

* wip

* wip

* wip

* wip

* wip

* Ignore payment_method_types on pay method

* Add payWith method

* Add findPayment method

Co-authored-by: Dries Vints <[email protected]>
    @driesvints
    [13.x] Allow options with formatAmount (#1348)
    bccbfbb 
    * Allow options with formatAmount

* wip
    @driesvints
    Update Cashier.php
    d1ed7cb
    @driesvints @github-actions
    Update CHANGELOG
    65e7b35
    @driesvints
    Merge branch '13.x'
    8d42262 
    # Conflicts:
#	CHANGELOG.md
#	src/Cashier.php
    @driesvints
    Drop PHP 7.4 and Laravel v8 support (#1353)
    c55e763
    @driesvints
    Fix deprecation with Carbon on receipts (#1356)
    c324fb8
    @driesvints @taylorotwell
    [13.x] Discount improvements (#1354)
    8923591 
    * Improve discount handling

* wip

* wip

* formatting

Co-authored-by: Taylor Otwell <[email protected]>
    @driesvints
    Update Cashier.php
    e46f67f
    @driesvints @github-actions
    Update CHANGELOG
    99fecbd
    @driesvints
    Bump dompdf (#1360)
    127dffe
    @driesvints
    version
    87dea21
    @driesvints @github-actions
    Update CHANGELOG
    9cbc291
    @driesvints
    Fix reference to billable (#1363)
    3e8f1e6
    @ankurk91
    Allow stripe sdk v8 (#1365)
    e22b25f
    @driesvints @taylorotwell
    [13.x] Add new hasTrialExpired methods (#1366)
    fd9cb91 
    * Add new hasTrialExpired methods

* rename method

Co-authored-by: Taylor Otwell <[email protected]>
    @driesvints
    Update composer.json
    0026d17
    @driesvints
    Update Cashier.php
    7a762f5
    driesvints and others added 28 commits November 2, 2023 14:50
    @driesvints
    Update Cashier.php
    77e2f56
    @driesvints @github-actions
    Update CHANGELOG
    1f211a3
    @jonathanroy @taylorotwell
    Add support for Payment cancelation (#1596)
    f8dff8a 
    * add passthrough method to cancel PaymentIntent

* Update Payment.php

---------

Co-authored-by: Taylor Otwell <[email protected]>
    @driesvints
    Early return upcoming invoice (#1597)
    e03fc2f
    @driesvints
    version
    223b333
    @driesvints @github-actions
    Update CHANGELOG
    fdb3469
    @driesvints
    [14.x] Prevent confirm email when in Checkout (#1600)
    2d7c343 
    * Prevent confirm email when in Checkout

* wip
    @driesvints
    [14.x] Fix soft deleted customers (#1599)
    3a676cc 
    * Fix soft deleted customers

* wip
    @driesvints
    Update Cashier.php
    39d3f1f
    @driesvints @github-actions
    Update CHANGELOG
    cd5f3f0
    @jwjenkin
    Update PaymentMethod.php (#1601)
    c7ae07c 
    Update the docstring to return `void`, since that is what the `deletePaymentMethod` function actually returns
    @driesvints
    wip
    503d6a0
    @delassiter @driesvints @taylorotwell
    [14.x] Allow creation of checkouts with ui_mode=embedded (#1605)
    3e0ea73 
    * Allow creation of embedded checkouts

* wip

* Update Checkout.php

---------

Co-authored-by: Dries Vints <[email protected]>
Co-authored-by: Taylor Otwell <[email protected]>
    @driesvints
    Update Cashier.php
    46d8139
    @driesvints @github-actions
    Update CHANGELOG
    0edb532
    @nunomaduro
    Merge branch '14.x'
    64715f9
    @driesvints
    Rename receipt to invoice (#1609)
    bed3ea9
    @nunomaduro
    [15.x] Stops using loadMigrationsFrom (#1613)
    0aacd50 
    * Stops using `loadMigrationsFrom`

* Adjusts upgrade guide

* Bumps testbench
    @driesvints @taylorotwell
    Add note about test rate limiting (#1612)
    0d38b0c 
    * Add note about test rate limiting

* Update CONTRIBUTING.md

---------

Co-authored-by: Taylor Otwell <[email protected]>
    @driesvints
    Merge branch '14.x'
    746a853
    @driesvints
    [15.x] Stripe API and SDK update (#1615)
    acc947b 
    * Stripe API and SDK update

* wip

* wip

* wip
    @driesvints
    Bump Laravel and PHP versions (#1616)
    7ea5261
    @driesvints
    Fetch all payment methods (#1617)
    f0e29ad
    @driesvints
    Change "name" column to "type" (#1620)
    2205495
    @driesvints
    wip
    c86e01e
    @orkhanahmadov
    Use container to resolve StripeClient (#1624)
    0627ac3
    @driesvints
    Merge branch '14.x'
    aa8ec66
    @driesvints @taylorotwell
    v15 upgrade guide (#1625)
    ac6b768 
    * v15 upgrade guide

* Update UPGRADE.md

---------

Co-authored-by: Taylor Otwell <[email protected]>
    @taylorotwell taylorotwell deleted the branch UnicornGlobal:master December 22, 2023 14:22
    @taylorotwell taylorotwell deleted the master branch December 22, 2023 14:22
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @steveops steveops Awaiting requested review from steveops

    Assignees
    No one assigned
    Labels
    🔍 Ready for Review Pull Request is not reviewed yet size/XXL
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.