Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering after stateless incidents via button #383

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

podliashanyk
Copy link
Contributor

Option "Open": only open and stateful incidents; Option "Closed": only closed and stateful incidents; Option "Stateless": open/closed (for legacy incidents that may be present in db) but stateless incidents; Option "All": open/closed and stateless/stateful incidents. "Open state" Button switch is renamed to "Progress state".

Closes #356

Option "Open": only open and stateful incidents; Option "Closed": only closed and stateful incidents; Option "Stateless": open/closed (for legacy incidents that may be present in db) but stateless incidents; Option "All": open/closed and stateless/stateful incidents. "Open state" Button switch is renamed to "Progress state".
@podliashanyk podliashanyk requested a review from hmpf June 16, 2022 12:50
@podliashanyk podliashanyk self-assigned this Jun 16, 2022
Ilona Podliashanyk added 4 commits June 16, 2022 15:18
Replaces "Open"/"Closed" badge with "Stateless" for stateless incidents. Changes colour of "Acked"/"Unacked" badge with blur for stateless incidents.
@podliashanyk podliashanyk changed the title Add filtering after stateless incidents Add filtering after stateless incidents via button Jun 17, 2022
@podliashanyk
Copy link
Contributor Author

podliashanyk commented Aug 24, 2022

After conversation with @lunkwill42:
It seems like the need for frontend-modifications regarding stateless incidents are unnecessary.
What Service Center wants, can be achieved by setting Severity to lower than 5. Additionally, alarm systems will not flood Argus with stateless incidents anymore (is that correct @lunkwill42?).
It seems there was a misunderstanding regarding what stateless incidents actually represent.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #383 (298d0aa) into master (de1c5ac) will increase coverage by 0.59%.
The diff coverage is 72.22%.

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   53.27%   53.86%   +0.59%     
==========================================
  Files          80       80              
  Lines        2981     3052      +71     
  Branches      651      681      +30     
==========================================
+ Hits         1588     1644      +56     
- Misses       1387     1402      +15     
  Partials        6        6              
Impacted Files Coverage Δ
src/components/filterprovider.tsx 81.70% <ø> (ø)
src/components/incident/IncidentDetails.tsx 4.40% <ø> (ø)
src/components/incidenttable/IncidentTable.tsx 72.14% <ø> (ø)
src/components/incident/IncidentFilterToolbar.tsx 58.44% <40.00%> (-2.81%) ⬇️
src/utils.tsx 61.58% <87.50%> (+8.68%) ⬆️
src/components/filteredincidentprovider.tsx 93.87% <100.00%> (+0.54%) ⬆️
src/components/incident/Chips.tsx 63.82% <100.00%> (ø)
.../components/incidenttable/IncidentTableToolbar.tsx 92.22% <100.00%> (+1.31%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
27.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "stateless"-button to filter on incidents-page
3 participants