Center content of destinations page #1078
Conversation
stveit
force-pushed
the
htmx-destinations-centre-content
branch
from
5ba4172 to
0508a61
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1078 +/- ##
=======================================
Coverage 81.19% 81.19%
=======================================
Files 140 140
Lines 5074 5074
=======================================
Hits 4120 4120
Misses 954 954 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Good start! 🙌
Although there are additional changes to be made in order to stabilize the width properties of the items in this flexbox. If destination collapse element is collapsed, it becomes very short. I would suggest to add following to the #form-list-div and form in _create_form.html: class="max-w-4xl w-full". This way we ensure that each item doesn't extend a max width of 56rem (896px), yet it will always try to extend to 896px if possible (because of w-full). This way we have a nice stable width which with a few extra tweaks (separate PR) would make destinations page responsive to different screen sizes.
I would also suggest to center contents of the create form and collapse-content, looks much prettier together with width changes suggested above.
Fixes #1079