-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document design philosophy #737
base: master
Are you sure you want to change the base?
Conversation
src/argus/workarounds.py
Outdated
else: | ||
ssl_context = ssl.create_default_context() | ||
ssl_context.check_hostname = False | ||
ssl_context.verify_mode = ssl.CERT_NONE |
Check failure
Code scanning / SonarCloud
Server certificates should be verified during SSL/TLS connections
src/argus/workarounds.py
Outdated
ssl_context.load_cert_chain(self.ssl_certfile, self.ssl_keyfile) | ||
return ssl_context | ||
else: | ||
ssl_context = ssl.create_default_context() |
Check failure
Code scanning / SonarCloud
Server hostnames should be verified during SSL/TLS connections
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #737 +/- ##
=======================================
Coverage 79.43% 79.43%
=======================================
Files 73 73
Lines 3608 3608
=======================================
Hits 2866 2866
Misses 742 742 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few typo fixes and small comments, not a proper full review
* incident | ||
* happening | ||
* event | ||
* .. se synonym dictionary for more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* .. se synonym dictionary for more | |
* .. see synonym dictionary for more |
An *incident* is reported (pushed) by a machine *source*. That source has a *type*. Any | ||
change in the incident at the source is reported by the source as an *event*. | ||
Any changes done by humans on a specific incident are also reported as an | ||
*event*. The machine source can categorize incidents via *tags*, but argus does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*event*. The machine source can categorize incidents via *tags*, but argus does | |
*event*. The machine source can categorize incidents via *tags*, but Argus does |
|
||
Argus was started to solve three problems: | ||
|
||
1. To aggregate/collect incidents from multiple NAV's without having to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a link to NAV here for people who don't know of NAV?
|
||
* Argus is not an inventory system | ||
* Argus is not a monitoring system, real-time or other | ||
* There is no pull. The source pushes incidents, argus pushes notifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* There is no pull. The source pushes incidents, argus pushes notifications. | |
* There is no pull. The source pushes incidents, Argus pushes notifications. |
.. [1] There is of course Boolean logic underlying the filters but we will | ||
never allow the full expressitivity | ||
.. [2] There is no way to send notifications for ALL incidents/events. The | ||
closes you can get is sending for all stateful incidents, which will then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closes you can get is sending for all stateful incidents, which will then | |
closest you can get is sending for all stateful incidents, which will then |
never allow the full expressitivity | ||
.. [2] There is no way to send notifications for ALL incidents/events. The | ||
closes you can get is sending for all stateful incidents, which will then | ||
not allow sending for stateless incidents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, if we decide to merge #701 it will be possible to send notifications for everything by having all event types in the filter
Quality Gate passedIssues Measures |
Document Argus's fundamental design philosophy in order to head off certain features at the pass.