Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff Github action for critical linting #918

Conversation

johannaengland
Copy link
Contributor

To make it more independent of tox.

changed-files needs to be included back before merging.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (b5e8382) to head (fbe9b6c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #918   +/-   ##
=======================================
  Coverage   83.36%   83.36%           
=======================================
  Files          98       98           
  Lines        4149     4149           
=======================================
  Hits         3459     3459           
  Misses        690      690           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean by "make it more independent of tox", but I approve of a solution that moves the "heavy lifting" to a pre-defined action.

@johannaengland johannaengland force-pushed the workflows/critical-linting-independent-tox branch from 96a8a36 to fbe9b6c Compare October 24, 2024 07:23
Copy link

@johannaengland johannaengland merged commit b292349 into Uninett:master Oct 24, 2024
10 of 11 checks passed
@johannaengland johannaengland deleted the workflows/critical-linting-independent-tox branch October 24, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants