-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to toggle django-debug-toolbar with envvar #977
Conversation
nice, perhaps we can even throw in an |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #977 +/- ##
==========================================
- Coverage 81.93% 80.75% -1.19%
==========================================
Files 132 123 -9
Lines 4861 4188 -673
==========================================
- Hits 3983 3382 -601
+ Misses 878 806 -72 ☔ View full report in Codecov by Sentry. |
e7914d5
to
139ed66
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This did not work out of the box, though.
I've never used Django Debug Toolbar at all before, and it seems it's not enough to add some environment variable to make it work in Argus.
I had to put at least these things into my settings file as well, to make Django Debug Toolbar appear:
DEBUG=True
INTERNAL_IPS = [
"127.0.0.1",
]
DEBUG_TOOLBAR_CONFIG = {
"ROOT_TAG_EXTRA_ATTRS": "hx-preserve"
}
If you have to manipulate your settings file to make it work anyway, why bother with the environment variable? Why not just have a how-to that shows a complete settings file example instead?
That INTERNAL_IPS isn't explicitly set the same for everyone is a problem, see #1113. We should probably document it as well. DEBUG is preferably controlled by an environment variable, hard-coding it anywhere would prevent that. It works for me without the DEBUG_TOOLBAR_CONFIG-bit but I can't see how adding it will hurt so I have updated the example accordingly. |
Co-authored-by: Morten Brekkevold <[email protected]>
Quality Gate passedIssues Measures |
No description provided.