Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to Zino *1* #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Jun 17, 2024

Closes #91

@hmpf hmpf added the documentation Improvements or additions to documentation label Jun 17, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@900367c). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage        ?   48.60%           
=======================================
  Files           ?       16           
  Lines           ?     1004           
  Branches        ?        0           
=======================================
  Hits            ?      488           
  Misses          ?      516           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test results

    4 files      4 suites   9s ⏱️
  38 tests   38 ✔️ 0 💤 0
152 runs  152 ✔️ 0 💤 0

Results for commit 11780c6.

Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the section Configuration there is also a variable HOWITZ_ZINO1_SERVER mentioned, is that one still called that way? If so, it would be good to rename that one as well

README.rst Outdated Show resolved Hide resolved
README.rst Outdated
@@ -2,6 +2,11 @@
Howitz - Zino web client with HTMx and Flask
============================================

Howitz is a HTTP client interface to Zino, an snmp network monitor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Howitz is a HTTP client interface to Zino, an snmp network monitor.
Howitz is a HTTP client interface to Zino, an SNMP network monitor.

Comment on lines +338 to +358
There are plans for an HTTP REST-based protocol in the python-based zino
server. When this protocol is finalized, we plan that howitz will also
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are plans for an HTTP REST-based protocol in the python-based zino
server. When this protocol is finalized, we plan that howitz will also
There are plans for an HTTP REST-based protocol in the Python-based Zino
server. When this protocol is finalized, we plan that Howitz will also

@hmpf hmpf requested a review from johannaengland June 17, 2024 13:01
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@hmpf hmpf requested a review from johannaengland June 19, 2024 08:30
@hmpf
Copy link
Contributor Author

hmpf commented Jun 19, 2024

Rebased on newest main which also had changes in README.rst.

Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merging of the main branch seemingly reverted some of my already committed suggestions, so I unresolved these again.

And my comment about HOWITZ_ZINO1_SERVER still stands as well

Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After IRL discussion regarding HOWITZ_ZINO1_SERVER and other config values containing "ZINO1": I suggest @lunkwill42 also takes a look at it as well before merging since it was him who requested this change in a separate PR.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, just a tiny suggestion added :)

Howitz is an HTTP client interface to Zino, an snmp network monitor.

Howitz currently works with the original Zino protocol. Where "Zino server" is
mentioned, we mean a Zino server using the original protocol.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mentioned, we mean a Zino server using the original protocol.
mentioned, we mean a Zino server using the legacy protocol.

@@ -2,6 +2,11 @@
Howitz - Zino web client with HTMx and Flask
============================================

Howitz is an HTTP client interface to Zino, an snmp network monitor.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Johanna suggested this, but it seems it got lost somewhere:

Suggested change
Howitz is an HTTP client interface to Zino, an snmp network monitor.
Howitz is an HTTP client interface to Zino, an SNMP network monitor.

@hmpf hmpf self-assigned this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop references to a specific Zino server version in README
5 participants