-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all references to Zino *1* #122
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
=======================================
Coverage ? 48.60%
=======================================
Files ? 16
Lines ? 1004
Branches ? 0
=======================================
Hits ? 488
Misses ? 516
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the section Configuration there is also a variable HOWITZ_ZINO1_SERVER
mentioned, is that one still called that way? If so, it would be good to rename that one as well
README.rst
Outdated
@@ -2,6 +2,11 @@ | |||
Howitz - Zino web client with HTMx and Flask | |||
============================================ | |||
|
|||
Howitz is a HTTP client interface to Zino, an snmp network monitor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Howitz is a HTTP client interface to Zino, an snmp network monitor. | |
Howitz is a HTTP client interface to Zino, an SNMP network monitor. |
There are plans for an HTTP REST-based protocol in the python-based zino | ||
server. When this protocol is finalized, we plan that howitz will also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are plans for an HTTP REST-based protocol in the python-based zino | |
server. When this protocol is finalized, we plan that howitz will also | |
There are plans for an HTTP REST-based protocol in the Python-based Zino | |
server. When this protocol is finalized, we plan that Howitz will also |
Rebased on newest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The merging of the main
branch seemingly reverted some of my already committed suggestions, so I unresolved these again.
And my comment about HOWITZ_ZINO1_SERVER
still stands as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After IRL discussion regarding HOWITZ_ZINO1_SERVER
and other config values containing "ZINO1": I suggest @lunkwill42 also takes a look at it as well before merging since it was him who requested this change in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, just a tiny suggestion added :)
Howitz is an HTTP client interface to Zino, an snmp network monitor. | ||
|
||
Howitz currently works with the original Zino protocol. Where "Zino server" is | ||
mentioned, we mean a Zino server using the original protocol. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mentioned, we mean a Zino server using the original protocol. | |
mentioned, we mean a Zino server using the legacy protocol. |
@@ -2,6 +2,11 @@ | |||
Howitz - Zino web client with HTMx and Flask | |||
============================================ | |||
|
|||
Howitz is an HTTP client interface to Zino, an snmp network monitor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Johanna suggested this, but it seems it got lost somewhere:
Howitz is an HTTP client interface to Zino, an snmp network monitor. | |
Howitz is an HTTP client interface to Zino, an SNMP network monitor. |
Closes #91