Skip to content

Commit

Permalink
Lock CI workflows to tox<4
Browse files Browse the repository at this point in the history
Tox 4 was released last month, and has since released 23 patch
releases. All of them break compatibility with our tox.ini in two
important regards:

`passenv` is no longer a space separated glob list, it seem it needs to
be a comma-separated one.

More importantly, tox no longer interprets quotes in commands - it
interprets them literally and feeds them as verbatim arguments to the
called commands, causing every command in our tox.ini file that uses
quotes to fail.
  • Loading branch information
lunkwill42 committed Jan 3, 2023
1 parent 9203e9c commit 0d5e8d1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
- name: "Install test runner dependencies"
run: |
set -xe
python -m pip install --upgrade pip setuptools wheel tox tox-gh-actions coverage virtualenv snmpsim
python -m pip install --upgrade pip setuptools wheel 'tox<4' tox-gh-actions coverage virtualenv snmpsim
sudo apt-get install -y nbtscan
# virtualenv seems to currently be embedding a broken version of
Expand Down

0 comments on commit 0d5e8d1

Please sign in to comment.