Skip to content

Commit

Permalink
Remove SonarCloud from workflow
Browse files Browse the repository at this point in the history
It is useless in most of our workflows, since our PRs mostly come from
external forks, which cannot access the secret SONAR_TOKEN.

Running SonarCloud on automatic instead.
  • Loading branch information
lunkwill42 committed Dec 8, 2021
1 parent 77b6a02 commit 4667469
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,16 +116,4 @@ jobs:
echo
done
sonarcloud:
name: SonarCloud
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
- name: SonarCloud Scan
uses: SonarSource/sonarcloud-github-action@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

0 comments on commit 4667469

Please sign in to comment.