Skip to content

Commit

Permalink
Lock urllib3<2.0
Browse files Browse the repository at this point in the history
`selenium` and `requests` depend on `urllib3`, which recently released
version 2.0.

The version of selenium we are using for driving our functional tests
doesn't appear to be compatible with this new major version, causing all
selenium-based tests to fail.
  • Loading branch information
lunkwill42 committed May 25, 2023
1 parent 1bceec4 commit 5b394ee
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,5 @@ whitenoise==4.1.4
# the next dep is here because newer versions of ciscoconfparse has broken dependencies
# this can be removed once we move to napalm 4, which no longer depends on ciscoconfparse
ciscoconfparse<1.6.51
# Our version of selenium breaks down if it is allowed to pull in the newest version of urllib3
urllib3<2.0

0 comments on commit 5b394ee

Please sign in to comment.