Skip to content

Commit

Permalink
Lock pyasn1<0.5.0
Browse files Browse the repository at this point in the history
`snmpsim` depends on `pyasn1`, but does not lock the dependent
version. `pyasn1` version 0.5.0 was recently released, and it seems
`snmpsim` is incompatible with the new version, causing integration
tests that use snmpsim to fail.

This locks pyasn1 to a version that should still work with the latest
version of snmpsim.
  • Loading branch information
lunkwill42 committed May 24, 2023
1 parent 87957ad commit 72f241a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- name: "Install test runner dependencies"
run: |
set -xe
python -m pip install --upgrade pip setuptools wheel 'tox<4' tox-gh-actions coverage virtualenv snmpsim
python -m pip install --upgrade pip setuptools wheel 'tox<4' tox-gh-actions coverage virtualenv snmpsim 'pyasn1<0.5.0'
sudo apt-get install -y nbtscan
# virtualenv seems to currently be embedding a broken version of
Expand Down
2 changes: 1 addition & 1 deletion tests/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ RUN cd /tmp && \
mv chromedriver /usr/local/bin/

# Install our primary test runner
RUN python3.7 -m pip install 'tox<4' snmpsim virtualenv
RUN python3.7 -m pip install 'tox<4' snmpsim 'pyasn1<0.5.0' virtualenv

# Add a build user
ENV USER build
Expand Down

0 comments on commit 72f241a

Please sign in to comment.