Collect dhcp-stats lacking "vlan" in the location #2555
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2555 +/- ##
=======================================
Coverage 56.69% 56.69%
=======================================
Files 602 602
Lines 43971 43971
=======================================
Hits 24931 24931
Misses 19040 19040 ☔ View full report in Codecov by Sentry. |
hmpf
force-pushed
the
dhcpd-stats-script
branch
from
bd5c659 to
7a51f6a
Compare
There was a problem hiding this comment.
I'm reading the README and I don't fully understand the references to "location keys in dhcpd-pools".
IIRC, the script looks at the "shared networks" section of dhcpd-pools output. Each network definition from the DHCP config has a name.
The point we're trying to get across is that this script tries to interpret a VLAN tag and/or location name from this DHCP network name, to use as part of the generated Graphite metric name - with the end goal being that NAV will be able to associate the metric with one of the VLANs/broadcast domains it knows from the routers it monitors.
|
Dhcpd-pool never talks about DHCP network names, only about locations. |
|
Kudos, SonarCloud Quality Gate passed!
|
hmpf
force-pushed
the
dhcpd-stats-script
branch
from
8dd5deb to
1513521
Compare
|
hmpf
force-pushed
the
dhcpd-stats-script
branch
2 times, most recently
from
605413c to
c7ab553
Compare
hmpf
force-pushed
the
dhcpd-stats-script
branch
6 times, most recently
from
325a8c7 to
3f2e4fb
Compare
|
Make fewer assumptions about what "location" looks like