Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize nav packaging #2655

Merged
merged 12 commits into from
Sep 6, 2023
Merged

Modernize nav packaging #2655

merged 12 commits into from
Sep 6, 2023

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Aug 8, 2023

First steps in modernizing how nav is built and packaged.

@hmpf hmpf self-assigned this Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2655 (3d9e2fe) into master (83224bf) will increase coverage by 0.50%.
Report is 56 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2655      +/-   ##
==========================================
+ Coverage   54.61%   55.12%   +0.50%     
==========================================
  Files         560      561       +1     
  Lines       40712    41459     +747     
==========================================
+ Hits        22235    22854     +619     
- Misses      18477    18605     +128     

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely look into improving how the SASS build process works.

@hmpf hmpf force-pushed the modernize-nav-packaging branch 2 times, most recently from 999d9ac to 5a078b0 Compare August 9, 2023 12:04
@hmpf hmpf force-pushed the modernize-nav-packaging branch from 82edcc7 to dff999b Compare August 28, 2023 11:21
@hmpf hmpf marked this pull request as ready for review August 28, 2023 11:34
@hmpf
Copy link
Contributor Author

hmpf commented Aug 28, 2023

This PR picks the low-hanging fruit. It does not:

@hmpf hmpf requested a review from lunkwill42 August 28, 2023 11:38
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works just fine with test suite and inside the dev containers. I will try to test Debianizing it.

And, I assume perhaps the install guides need to be updated just a tiny bit (the "install from source"-ones)

Co-authored-by: Morten Brekkevold <[email protected]>
@hmpf hmpf requested a review from lunkwill42 September 5, 2023 12:42
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hmpf hmpf merged commit 7adced3 into master Sep 6, 2023
@hmpf hmpf deleted the modernize-nav-packaging branch September 6, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants