-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize nav packaging #2655
Modernize nav packaging #2655
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2655 +/- ##
==========================================
+ Coverage 54.61% 55.12% +0.50%
==========================================
Files 560 561 +1
Lines 40712 41459 +747
==========================================
+ Hits 22235 22854 +619
- Misses 18477 18605 +128 see 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely look into improving how the SASS build process works.
999d9ac
to
5a078b0
Compare
The top-level `etc/` directory hasn't existed for a few years now.
As per tox 4 syntax, also makes it look like all other keys that takes lists.
82edcc7
to
dff999b
Compare
This PR picks the low-hanging fruit. It does not:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works just fine with test suite and inside the dev containers. I will try to test Debianizing it.
And, I assume perhaps the install guides need to be updated just a tiny bit (the "install from source"-ones)
Co-authored-by: Morten Brekkevold <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
First steps in modernizing how nav is built and packaged.