Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use form for expression validation in alert profiles #2667

Merged
merged 3 commits into from
Sep 6, 2023

Add tests for adding expression to filters

ef27237
Select commit
Loading
Failed to load commit list.
Merged

Use form for expression validation in alert profiles #2667

Add tests for adding expression to filters
ef27237
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/patch succeeded Sep 6, 2023 in 0s

93.75% of diff hit (target 54.13%)

View this Pull Request on Codecov

93.75% of diff hit (target 54.13%)

Annotations

Check warning on line 560 in python/nav/web/alertprofiles/forms.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/nav/web/alertprofiles/forms.py#L560 

Added line #L560 was not covered by tests

Check warning on line 1568 in python/nav/web/alertprofiles/views.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/nav/web/alertprofiles/views.py#L1567-L1568 

Added lines #L1567 - L1568 were not covered by tests
View more details on Codecov