Show blacklisted reason of alert address in alert profiles #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannaengland
requested review from
lunkwill42,
hmpf,
stveit and
podliashanyk
johannaengland
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2677 +/- ##
=======================================
Coverage 55.03% 55.03%
=======================================
Files 561 561
Lines 40882 40882
=======================================
Hits 22498 22498
Misses 18384 18384 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lunkwill42
force-pushed
the
show-blacklisted-reason-in-UI
branch
from
e01d3aa to
aea5b83
Compare
"Blacklisting" is a very internal concept in AlertEngine. The net effect for users editing their profiles is that an alert sender is currently non-functional, for some reason. This changes the UI to just refer to the address types as currently non-functional.
lunkwill42
approved these changes
Sep 7, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2653.
I modeled it after how it is shown when an alert sender is no longer supported, but used the warning box instead of the error box.
(basically copied 8b2700c)
Dependent on #2678.