Prevent error when setting new default for multiple existing default dashboards #2680
Conversation
There was a problem hiding this comment.
Looks like a useful solution.
The tests were failing because you forgot to consider that dashboards are personal, so when there are multiple users, there will be multiple dashboard objects with the is_default attribute set to True.
(And there are always at least two users in a new NAV install, one representing the anonymous default user, and one representing the admin account)
I've pushed my suggested update to the tests...
Codecov Report
@@ Coverage Diff @@
## 5.7.x #2680 +/- ##
==========================================
+ Coverage 55.17% 55.19% +0.02%
==========================================
Files 561 561
Lines 40921 40917 -4
==========================================
+ Hits 22577 22584 +7
+ Misses 18344 18333 -11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
For some reason we ended up with multiple default dashboards This fix will make setting a new one possible
johannaengland
force-pushed
the
bugfix/fix-multiple-default-dashboards
branch
from
d8c372d to
f5c0427
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
For some reason it happened that for multiple dashboards the
is_defaultfield is set to True, which leads to an error when trying to set a new dashboard as the default. This fixes that situation without doing anything about the underlying problem.