Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix related names of NetmapView #2683

Merged

Conversation

johannaengland
Copy link
Contributor

Closes #2681.

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2683 (6254fd0) into 5.7.x (25e4b32) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##            5.7.x    #2683   +/-   ##
=======================================
  Coverage   55.17%   55.17%           
=======================================
  Files         561      561           
  Lines       40921    40921           
=======================================
  Hits        22577    22577           
  Misses      18344    18344           
Files Changed Coverage Δ
python/nav/netmap/topology.py 82.35% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I assume the lack of test coverage here is why we didn't catch this before the 5.7.0 release, so a further challenge here might be to actually add some coverage...

@github-actions
Copy link

Test results

     12 files       12 suites   15m 36s ⏱️
3 215 tests 3 215 ✔️ 0 💤 0
9 120 runs  9 120 ✔️ 0 💤 0

Results for commit 6254fd0.

@johannaengland johannaengland merged commit 3ecbb92 into Uninett:5.7.x Sep 14, 2023
9 of 10 checks passed
@johannaengland johannaengland deleted the bugfix/netmap-related-names branch September 14, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants