-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper validation for phone numbers #2694
Add proper validation for phone numbers #2694
Conversation
52c5bce
to
7022311
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## master #2694 +/- ##
=======================================
Coverage 55.19% 55.19%
=======================================
Files 561 561
Lines 40917 40917
=======================================
Hits 22584 22584
Misses 18333 18333
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better for the NAV specifics :)
A reminder though, that we do have access to many real-world values through our customer installations. We could extract those just for a quick test against real data (not disclosing anything to the world, though)
I have just tested this against all real-world values I have access to and all works. |
Closes #2662.