Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper validation for phone numbers #2694

Conversation

johannaengland
Copy link
Contributor

Closes #2662.

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Test results

     12 files       12 suites   13m 17s ⏱️
3 220 tests 3 220 ✔️ 0 💤 0
9 135 runs  9 135 ✔️ 0 💤 0

Results for commit 7022311.

♻️ This comment has been updated with latest results.

@johannaengland johannaengland force-pushed the alertengine/validate-phone-numbers branch from 52c5bce to 7022311 Compare November 1, 2023 09:47
Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #2694 (7022311) into master (e879e67) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2694   +/-   ##
=======================================
  Coverage   55.19%   55.19%           
=======================================
  Files         561      561           
  Lines       40917    40917           
=======================================
  Hits        22584    22584           
  Misses      18333    18333           
Files Coverage Δ
...thon/nav/alertengine/dispatchers/sms_dispatcher.py 44.11% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better for the NAV specifics :)

A reminder though, that we do have access to many real-world values through our customer installations. We could extract those just for a quick test against real data (not disclosing anything to the world, though)

@johannaengland
Copy link
Contributor Author

I have just tested this against all real-world values I have access to and all works.

@johannaengland johannaengland merged commit e297772 into Uninett:master Nov 2, 2023
11 checks passed
@johannaengland johannaengland deleted the alertengine/validate-phone-numbers branch November 2, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Phone numbers in alert addresses are not validated
2 participants