Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to threshold alarms #2709

Merged

Conversation

johannaengland
Copy link
Contributor

Closes #2691.

@johannaengland johannaengland self-assigned this Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

Test results

     12 files       12 suites   12m 41s ⏱️
3 221 tests 3 221 ✔️ 0 💤 0
9 138 runs  9 138 ✔️ 0 💤 0

Results for commit 891607e.

♻️ This comment has been updated with latest results.

@johannaengland johannaengland force-pushed the threshold-alarms-add-description branch from 143ca64 to 891607e Compare November 2, 2023 14:23
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2709 (891607e) into master (e297772) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2709      +/-   ##
==========================================
- Coverage   55.19%   55.19%   -0.01%     
==========================================
  Files         561      561              
  Lines       40917    40919       +2     
==========================================
+ Hits        22584    22585       +1     
- Misses      18333    18334       +1     
Files Coverage Δ
python/nav/thresholdmon.py 66.15% <50.00%> (-0.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@johannaengland johannaengland merged commit 624f671 into Uninett:master Nov 14, 2023
9 of 11 checks passed
@johannaengland johannaengland deleted the threshold-alarms-add-description branch November 14, 2023 12:56
lunkwill42 added a commit that referenced this pull request Nov 27, 2023
This was somehow missed by the changelog auto generator before the release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Description to threshold alarms
2 participants