Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken docs environment in tox.ini #2720

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

lunkwill42
Copy link
Member

@lunkwill42 lunkwill42 commented Nov 8, 2023

Discovered during #2716

Closes #2714

Our requirements files already lock libsass to 0.15.1, but since the
pyproject.toml file doesn't, it leads to problems when building e.g. tox
environments on some Linux distros (particularly, on NixOS, it ends up
download a Python egg with a binary that declares dynamic dependencies
incompatible with NixOS)
Various strange problems (that differ between developers) kept cropping
up when trying to build the docs environment using the "old" method with
pip-tools.

This resets the doc environment to look more like we now handle the
default testenv in tox.ini, and should therefore also fix the doc builds.
@lunkwill42 lunkwill42 self-assigned this Nov 8, 2023
@lunkwill42 lunkwill42 added the documentation Related to documentation of NAV label Nov 8, 2023
@hmpf hmpf self-requested a review November 8, 2023 11:36
Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes it for me.

Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2720 (2954636) into master (b7625d7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2720   +/-   ##
=======================================
  Coverage   55.19%   55.19%           
=======================================
  Files         561      561           
  Lines       40917    40917           
=======================================
  Hits        22584    22584           
  Misses      18333    18333           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

github-actions bot commented Nov 8, 2023

Test results

     12 files       12 suites   12m 48s ⏱️
3 221 tests 3 221 ✔️ 0 💤 0
9 138 runs  9 138 ✔️ 0 💤 0

Results for commit 2954636.

@hmpf hmpf merged commit 2936956 into Uninett:master Nov 8, 2023
@lunkwill42 lunkwill42 deleted the doc/fix-tox-build branch November 8, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation of NAV
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] "tox -e docs" fails
2 participants