Add SNMPv3 support to navsnmp command #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunkwill42
force-pushed
the
feature/snmpv3-navsnmp
branch
from
7abbb9f to
bec2c02
Compare
hmpf
reviewed
Nov 13, 2023
lunkwill42
force-pushed
the
feature/snmpv3-navsnmp
branch
from
bec2c02 to
b9a8398
Compare
The navsnmp command needed to be able to output NET-SNMP command line parameters for SNMPv3 profiles too. Slightly restructured the code, since outputting SNMPv3 arguments is slightly more complex that just outputting a community string :)
As suggested in code review, this adds an actual docstring to the script, and reuses the docstring as the ArgumentParser description.
lunkwill42
force-pushed
the
feature/snmpv3-navsnmp
branch
from
b9a8398 to
d156f91
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
johannaengland
approved these changes
Nov 13, 2023
Codecov Report
@@ Coverage Diff @@
## master #2725 +/- ##
=======================================
Coverage 55.32% 55.32%
=======================================
Files 567 567
Lines 41052 41052
=======================================
Hits 22713 22713
Misses 18339 18339 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The navsnmp command needed to be able to output NET-SNMP command line parameters for SNMPv3 profiles too. Slightly restructured the code, since outputting SNMPv3 arguments is slightly more complex that just outputting a community string :)
Closes #2724