Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SNMPv3 write profile checks in SeedDB #2730

Merged

Conversation

lunkwill42
Copy link
Member

@lunkwill42 lunkwill42 commented Nov 10, 2023

This augments #2734 and closes #2727.

This includes reworking the snmpdv3 example container to allow for testing write operations.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0388823) 55.32% compared to head (2b6cfb6) 55.46%.
Report is 65 commits behind head on master.

Files Patch % Lines
python/nav/web/seeddb/page/netbox/edit.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2730      +/-   ##
==========================================
+ Coverage   55.32%   55.46%   +0.13%     
==========================================
  Files         567      567              
  Lines       41052    41175     +123     
==========================================
+ Hits        22713    22838     +125     
+ Misses      18339    18337       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 10, 2023

Test results

     12 files       12 suites   11m 25s ⏱️
3 256 tests 3 256 ✔️ 0 💤 0
9 243 runs  9 243 ✔️ 0 💤 0

Results for commit 2b6cfb6.

♻️ This comment has been updated with latest results.

hmpf
hmpf previously requested changes Nov 13, 2023
Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing function

python/nav/web/seeddb/page/netbox/edit.py Show resolved Hide resolved
@lunkwill42 lunkwill42 force-pushed the feature/snmpv3-seeddb-write-profiles branch from 55c77b8 to 23222a8 Compare November 13, 2023 10:00
@lunkwill42 lunkwill42 changed the base branch from snmpv3 to snmpv3-synchronous November 13, 2023 10:00
@lunkwill42 lunkwill42 requested a review from hmpf November 13, 2023 10:02
Enable write access to snmpdv3 instance as well, so that snmp SET
commands also can be tested properly.
This just makes the SeedDB write profile test work by delegating
SNMP session establishment to the new get_snmp_session_for_profile
function.
@lunkwill42 lunkwill42 force-pushed the feature/snmpv3-seeddb-write-profiles branch from 23222a8 to 2b6cfb6 Compare November 13, 2023 13:53
@lunkwill42 lunkwill42 changed the base branch from snmpv3-synchronous to master November 13, 2023 13:53
@lunkwill42 lunkwill42 dismissed hmpf’s stale review November 16, 2023 09:10

Stale review, this was fixed.

@lunkwill42 lunkwill42 closed this Nov 16, 2023
@lunkwill42 lunkwill42 reopened this Nov 16, 2023
Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lunkwill42 lunkwill42 merged commit be3cca1 into Uninett:master Nov 16, 2023
12 of 13 checks passed
@lunkwill42 lunkwill42 deleted the feature/snmpv3-seeddb-write-profiles branch November 16, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SeedDB writeable profile connectivity verification to support SNMPv3
3 participants