Make mod-auth-mellon (SAML!) work for logins #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out, mod-auth-mellon behaves differently on logout from mod-auth-openidc, looks like more config is needed. |
hmpf
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2740 +/- ##
=======================================
Coverage 55.61% 55.62%
=======================================
Files 567 567
Lines 41247 41253 +6
=======================================
+ Hits 22941 22947 +6
Misses 18306 18306 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
lunkwill42
approved these changes
Nov 22, 2023
Comment on lines
+21
to
+34
| This should create the following files:: | ||
|
|
||
| /etc/apache2/mods-available/auth_mellon.conf | ||
| /etc/apache2/mods-available/auth_mellon.load | ||
| /etc/apache2/mods-enabled/auth_mellon.conf | ||
| /etc/apache2/mods-enabled/auth_mellon.load | ||
|
|
||
| Enable with:: | ||
|
|
||
| $ sudo a2enmod auth_mellon | ||
|
|
||
| Disable with:: | ||
|
|
||
| $ sudo a2dismod auth_mellon |
There was a problem hiding this comment.
If if creates files in /etc/apache2/mods-enabled on installation, then it's already enabled. Is this really the default behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This piggy-backs on the remote user functionality.