Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for adding profile with time periods #2749

Conversation

johannaengland
Copy link
Contributor

Another improvement to the alert profiles tests.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba90a00) 55.51% compared to head (6eef925) 55.57%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2749      +/-   ##
==========================================
+ Coverage   55.51%   55.57%   +0.05%     
==========================================
  Files         567      567              
  Lines       41172    41172              
==========================================
+ Hits        22858    22880      +22     
+ Misses      18314    18292      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test results

     12 files       12 suites   11m 36s ⏱️
3 260 tests 3 260 ✔️ 0 💤 0
9 255 runs  9 255 ✔️ 0 💤 0

Results for commit 6eef925.

@johannaengland johannaengland merged commit 74a9c23 into Uninett:master Nov 21, 2023
13 checks passed
@johannaengland johannaengland deleted the tests/alertprofiles/add-profile-with-template branch November 21, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants