Allow write-enabled SNMP profiles to be used for reading when no read-only profiles are available #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have yet to properly verify that this works in real life, so keeping in Draft until then... |
lunkwill42
force-pushed
the
feature/fix-preferred-snmp-profile-logic
branch
4 times, most recently
from
cab6497 to
a8a3e4b
Compare
|
Tested and found to work, but in order to avoid needing to fix issues in the deprecated Netbox properties, this now depends on #2754 to merged first. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2751 +/- ##
=======================================
Coverage 55.62% 55.62%
=======================================
Files 567 567
Lines 41220 41224 +4
=======================================
+ Hits 22928 22932 +4
Misses 18292 18292 ☔ View full report in Codecov by Sentry. |
hmpf
approved these changes
Nov 20, 2023
This changes the logic behind preferred SNMP profile selection, a need that has become apparent while working with SNMPv3 profiles. A read-write profile should be acceptable for read operations if no read-only profile exists. However, if write access is not required, but a write profile is available in addition to a read profile, the read profile should be preferred. This also updates all callers to the new signature, based on their actual needs.
ManagementProfile.snmp_version now avoids crashing in the case of faulty SNMP profiles. Since it was used to sort multiple profiles in order of SNMP version while fetching preferred profiles, the presence of any faulty profile on a Netbox would make `get_preferred_snmp_profile()` unable to fetch any valid profile without crashing. This was discovered by our test suite.
lunkwill42
force-pushed
the
feature/fix-preferred-snmp-profile-logic
branch
from
a8a3e4b to
3ba3a24
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2735
Depends on #2754