Add more expression operator tests for alert profiles and fix cleaning in ExpressionForm #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2752 +/- ##
=======================================
Coverage 55.61% 55.61%
=======================================
Files 567 567
Lines 41247 41247
=======================================
Hits 22941 22941
Misses 18306 18306 ☔ View full report in Codecov by Sentry. |
hmpf
reviewed
Nov 20, 2023
hmpf
approved these changes
Nov 20, 2023
johannaengland
force-pushed
the
tests/alertprofiles/add-expression-tests
branch
from
94b3460 to
f325211
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more tests to make sure that all kind of values can be posted for all different operators.
That also revealed that only in case of the equal operator with values being selected from a list that value is then sent as a list. In case of sysname the value is still a string and therefore should not be cleaned the same way.
See the second commit for the specific test for that.