Frontend for configuring PoE in Portadmin #2759
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2759 +/- ##
==========================================
+ Coverage 55.62% 56.00% +0.38%
==========================================
Files 567 567
Lines 41224 41279 +55
==========================================
+ Hits 22932 23120 +188
+ Misses 18292 18159 -133 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
This rough-cut looks a bit ugly, and I'm not sure where I can actually test it (if we have functioning test equipment, please do DM me)
The issue with the rows of the interface table breaking into two lines seems to be because of the magic rules of the "faketable" used.
The table uses a small-12 style, which apparently means that all the columns use medium-* styles to indicate their relative sizes in the table. All the columns' usages of medium-* classes need to add up to the available 12, apparently (which is why there is some magic on the save button column, which takes into account another collapsible column that comes and goes - so you may have to do more of that magic to ensure everything always adds up to 12 :P )
|
I can now add that I've tested against a Juniper switch, and functionality-wise this seems golden. Don't have access to a Cisco device, though. |
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
This does the trick!
However, it doesn't look optimal if the screen size is reduced to, say, a typical iPad (but it looks ok on a phone-sized screen). I'm not going to bother you with fixing that in this PR, but let's post an issue to fix it later (and get a front-end dev involved)
Great work, @stveit !
Adds frontend elements for changing PoE state in portadmin