Fix SeedDB edit netbox regression #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audit logging netbox changes started crashing once deprecated attributes were removed.
These attributes/properties have been deprecated for some time, and have now been removed. This caused this comparison function to crash SeedDB when audit logging changes to netbox objects.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2761 +/- ##
=======================================
Coverage 55.65% 55.66%
=======================================
Files 567 567
Lines 41224 41224
=======================================
+ Hits 22942 22946 +4
+ Misses 18282 18278 -4 ☔ View full report in Codecov by Sentry. |
johannaengland
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression that appeared once deprecated attributes were removed from the
Netboxmodel in #2754 . The regression causes SeedDB to crash when making changes to Netbox objects.We had no tests in place to detect this issue, which also was not discovered by other linting tools, since the attribute accesses are dynamic.
This also adds a simple test to ensure the audit logging comparison doesn't crash.
(this regression was only on master, it never made it into a release)