Fix SNMP v1/v2c regression in async libraries #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SNMPParameters class expects its SNMP version attribute to be an integer. However, some (or perhaps all) SNMPv1/v2c management profiles tend to store the version numbers as strings, for some reason. The net result is that the `as_agentproxy_args()` method would fail to provide a `community` argument to SNMP v1/v2 sessions because it was unable to compare an integer version number to a string.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2763 +/- ##
=======================================
Coverage 56.04% 56.04%
=======================================
Files 567 567
Lines 41250 41251 +1
=======================================
+ Hits 23117 23118 +1
Misses 18133 18133 ☔ View full report in Codecov by Sentry. |
johannaengland
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SNMPParametersclass expects its SNMP version attribute to be an integer. However, some (or perhaps all) SNMPv1/v2c management profiles tend to store the version numbers as strings, for some reason.The net result is that the
as_agentproxy_args()method would fail to provide acommunityargument to SNMP v1/v2 sessions because it was unable to compare an integer version number to a string. This would causeipdevpoll/navoidverify/naventityto always usepublicas the SNMP community of all v1/v2c sessions.Fortunately, this did not make it into a release.