Parse SNMP profile version numbers using existing ManagementProfile.snmp_version property
#2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While all data we have has SNMPv2c profiles store their version number as either the string or the integer 2, some users report that they appear to be stored as the string `2c`, which crashes ipdevpoll's `SNMPParameters.factory()` method.
`ManagementProfile.snmp_version` already does the heavy lifting for us when it comes to parse the SNMP version value of an SNMP profile, so let's use that instead to avoid issues like the one described in Uninett#2767
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.8.x #2768 +/- ##
=======================================
Coverage 56.01% 56.01%
=======================================
Files 567 567
Lines 41279 41277 -2
=======================================
Hits 23121 23121
+ Misses 18158 18156 -2 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
johannaengland
approved these changes
Nov 27, 2023
hmpf
reviewed
Nov 28, 2023
hmpf
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2767 by moving the responsibility for "parsing" the snmp version value of a profile from the
SNMPParameters.factory()method to theManagementProfileobject itself.Regression tests included.