Ensure AgentProxy.snmpVersion is prefixed by v
#2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `snmpVersion` argument to `AgentProxy` is not a version string prefixed by the letter `v`, `AgentProxy` will silently default to `v2c`. Using `2c` as a value works, since it defaults then to `v2c`. Using `3` also seems to work, as providing further SNMPv3 configuration arguments to the Net-SNMP library seems to automatically set the session version to `v3`, regardless of the version parameter. However, using `1` will not work, as that will also silently default the session to `v2c`, making SNMPv1 communication impossible.
lunkwill42
changed the title
vAgentProxy.snmpVersion is prefixed by v
johannaengland
previously approved these changes
Dec 1, 2023
Now need to test that the version argument is actually prefixed by `v`
lunkwill42
force-pushed
the
bugfix/snmpv1-agentproxy-fixup
branch
from
5a7f7ed to
83e9eda
Compare
lunkwill42
force-pushed
the
bugfix/snmpv1-agentproxy-fixup
branch
from
83e9eda to
c679e56
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
hmpf
approved these changes
Dec 1, 2023
This was referenced Dec 4, 2023
This was
linked to
issues
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
snmpVersionargument toAgentProxyis not a version string prefixed by the letterv,AgentProxywill silently default tov2c.Using
2cas a value works, since it defaults then tov2c. Using3also seems to work, as providing further SNMPv3 configuration arguments to the Net-SNMP library seems to automatically set the session version tov3, regardless of the version parameter.However, using
1will not work, as that will also silently default the session tov2c, making SNMPv1 communication impossible.Fixes #2779
Fixes #2772