Fix save button moving for ports without PoE support #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.8.x #2782 +/- ##
=======================================
Coverage 57.03% 57.03%
=======================================
Files 567 567
Lines 41280 41280
=======================================
Hits 23544 23544
Misses 17736 17736 ☔ View full report in Codecov by Sentry. |
lunkwill42
requested changes
Dec 13, 2023
If poe column is active, which means some interfaces will have a poe state dropdown option, the lines that do not have a poe state dropdown still needs to occupy the space, else the save button will shift to the left and not be lined up with all the other save buttons.
This was probably left over from basing the Poe dropdown on the vlan dropdown
lunkwill42
force-pushed
the
portadmin/fix-save-button-shift-poe
branch
from
d8fbf85 to
a9aa56c
Compare
lunkwill42
approved these changes
Dec 14, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem that occurs if some ports support PoE and some dont. The lines that do not suppot PoE will not have a dropdown, so the space will not be occupied by anything. This causes the save button to move to the left, as seen below.
This PR makes it so the space is always occupied if the PoE column is active.
Also remove random vlan tag that shouldnt be there