Fix PoE State in portadmin not updating orig-value #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stveit
force-pushed
the
portadmin/fix-poe-dropdown-not-updating-orig-value
branch
from
38be656 to
fb3a412
Compare
|
Code smell complaint from SonarCloud, but the functionits complaining about is based on the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.8.x #2785 +/- ##
=======================================
Coverage 57.03% 57.03%
=======================================
Files 567 567
Lines 41280 41280
=======================================
Hits 23544 23544
Misses 17736 17736 ☔ View full report in Codecov by Sentry. |
lunkwill42
requested changes
Dec 13, 2023
lunkwill42
force-pushed
the
portadmin/fix-poe-dropdown-not-updating-orig-value
branch
from
fb3a412 to
50a90fb
Compare
lunkwill42
approved these changes
Dec 14, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem where if you change the PoE value and save, then try to go back to the original state the save button will not be active.
this was because the orig-value for the dropdown menu was not updated when saving. This PR updates the value on save and fixes the issue.