Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pkg_resources with importlib #2798

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Jan 5, 2024

Closes #2791

@hmpf hmpf marked this pull request as draft January 5, 2024 12:33
Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Jan 5, 2024

Test results

     12 files       12 suites   11m 27s ⏱️
3 303 tests 3 303 ✔️ 0 💤 0
9 384 runs  9 384 ✔️ 0 💤 0

Results for commit 9a871c9.

♻️ This comment has been updated with latest results.

@hmpf hmpf force-pushed the replace-pkgresources branch from 692a8ba to 6b8aadd Compare February 20, 2024 08:27
@hmpf hmpf marked this pull request as ready for review February 20, 2024 08:28
@hmpf hmpf self-assigned this Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 57.10%. Comparing base (8ea18f5) to head (9a871c9).

Files Patch % Lines
python/nav/buildconf.py 83.33% 1 Missing ⚠️
python/nav/config.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2798      +/-   ##
==========================================
+ Coverage   57.07%   57.10%   +0.02%     
==========================================
  Files         567      567              
  Lines       41255    41278      +23     
==========================================
+ Hits        23548    23571      +23     
  Misses      17707    17707              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmpf
Copy link
Contributor Author

hmpf commented Feb 20, 2024

These changes are not sufficient to make tests shut up about pkg_resources, (sub)dependencies use it too, see #2814

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, glad to get this sorted out.

These changes are not sufficient to make tests shut up about pkg_resources, (sub)dependencies use it too, see #2814

Indeed. Not really our problem, unless we can fix it by upgrading dependencies. Posted some comments to #2814 for followup.

python/nav/util.py Show resolved Hide resolved
python/nav/util.py Show resolved Hide resolved
python/nav/util.py Outdated Show resolved Hide resolved
@hmpf hmpf requested a review from lunkwill42 February 26, 2024 13:11
python/nav/util.py Outdated Show resolved Hide resolved
@hmpf hmpf force-pushed the replace-pkgresources branch from fd6797b to 9a871c9 Compare February 27, 2024 06:32
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hmpf hmpf merged commit de2a90b into Uninett:master Feb 27, 2024
12 checks passed
@hmpf hmpf deleted the replace-pkgresources branch February 27, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace all uses of pkg_resources with importlib
2 participants